Overlay Permission: display explanatory dialog for Android > R#12253
Merged
TobiGr merged 2 commits intoTeamNewPipe:devfrom Aug 27, 2025
Merged
Overlay Permission: display explanatory dialog for Android > R#12253TobiGr merged 2 commits intoTeamNewPipe:devfrom
TobiGr merged 2 commits intoTeamNewPipe:devfrom
Conversation
Profpatsch
changed the title
|
ShareASmile
added
feature request
Isira-Seneviratne
requested changes
Jul 22, 2025
app/src/main/java/org/schabi/newpipe/util/PermissionHelper.java
Outdated
Show resolved
Hide resolved
On Android > R, ACTION_MANAGE_OVERLAY_PERMISSION always brings the user to the app selection screen. https://developer.android.com/about/versions/11/privacy/permissions#manage_overlay This is highly confusing behaviour from the system, so let’s add an instruction before navigating to the settings menu.
TobiGr
force-pushed
the
popup-overlay-alert-dialog
branch
from
ce71834 to
74562db
Compare
TobiGr
approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Android > R, ACTION_MANAGE_OVERLAY_PERMISSION always brings the user to the app selection screen.
https://developer.android.com/about/versions/11/privacy/permissions#manage_overlay
This is highly confusing behaviour from the system, so let’s add an instruction before navigating to the settings menu.
What is it?
Before/After Screenshots/Screen Record
newpipe_popup_alert.mp4
Fixes the following issue(s)
No issue afaik
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence