SearchFragment: show service name in search hint#12258
Merged
Stypox merged 3 commits intoTeamNewPipe:devfrom Jul 16, 2025
Merged
SearchFragment: show service name in search hint#12258Stypox merged 3 commits intoTeamNewPipe:devfrom
Stypox merged 3 commits intoTeamNewPipe:devfrom
Conversation
The only hint (haha) which service one is searching in is currently the color of the background. This is super confusing, yesterday a friend tried to search for a video on youtube and the app was set to Bandcamp, and they were super confused why nothing turned up. So let’s put the name of the service in the hint! The `updateService()` thing is a little confused, but I didn’t want to refactor to improve the logic. It’s not doing anything computationally intensive anyway. For PeerTube, the sidebar calls it FramaTube but the service name is PeerTube, I’m not sure why that is the case. Looks like the string depends on the name of the instance? Hm, can be improved later I think.
AudricV
added
feature request
app/src/main/java/org/schabi/newpipe/fragments/list/search/SearchFragment.java
Show resolved
Hide resolved
ShareASmile
added
the
waiting for author
Stypox
approved these changes
Jun 4, 2025
Member
Stypox
left a comment
Stypox
left a comment
There was a problem hiding this comment.
Thanks! Feel free to merge after @snaik20 approves :-)
Profpatsch
commented
Jun 5, 2025
Contributor
Author
Profpatsch
left a comment
Profpatsch
left a comment
There was a problem hiding this comment.
Not happy with this, the original idea was that the service gets displayed, but now this does not show the service anymore when there’s a filter
Contributor
Author
|
Not even talking about the fact that there’s no distinction between youtube music playlists and youtube playlists for example. |
github-actions
bot
removed
the
waiting for author
This is still not perfect, but it will show the selected search filter in addition to the service name, like: “Search YouTube (Playlists)”. It will not distinguish between a YouTube Music and Youtube filter, so it will display the same thing. Could be improved, but then the text gets too long! :(
Contributor
Author
|
Okay, now it’s better: |
|
ShareASmile
added
the
ready for review
Stypox
approved these changes
Jul 16, 2025
| service.getServiceInfo().getName())); | ||
| } else { | ||
| searchEditText.setHint(getString(R.string.search_with_service_name, item.getTitle())); | ||
| if (service != null) { |
Member
There was a problem hiding this comment.
I guess this assumes the service is nonnull, because if it is null it won't show anything... But anyway, it doesn't make sense for the service to be null sooo...
ShareASmile
removed
the
ready for review
11 tasks
whistlingwoods
pushed a commit
to whistlingwoods/FoxPipe
that referenced
this pull request
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
The only hint (haha) which service one is searching in is currently the color of the background. This is super confusing, yesterday a friend tried to search for a video on youtube and the app was set to Bandcamp, and they were super confused why nothing turned up.
So let’s put the name of the service in the hint!
The
updateService()thing is a little confused, but I didn’t want to refactor to improve the logic. It’s not doing anything computationally intensive anyway.For PeerTube, the sidebar calls it FramaTube but the service name is PeerTube, I’m not sure why that is the case. Looks like the string depends on the name of the instance? Hm, can be improved later I think.
Before/After Screenshots/Screen Record
after:
newpipe_search_service_name.mp4
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence