-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Migrate XML-based views to Material 3 #12654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: refactor
Are you sure you want to change the base?
Migrate XML-based views to Material 3 #12654
Conversation
f2d9ad8 to
089c6b8
Compare
a07c3bd to
ca944f4
Compare
|
@Isira-Seneviratne : Nice work, why the button with the "+" (plus) in that color? Maybe this color looks better Look: https://material-foundation.github.io/material-theme-builder/ |
|
Cool, thanks! I have one complaint: the color of the top bar serves the purpose of giving an indication of which service is currently active, and now that indication is lost. So we should either bring back the colored bar (just in MainActivity), or we find some other way to clearly indicate which service is active. Maybe a chip in the top bar replacing the tab name? And then the tab name could be put next to the tab icon (only for the selected tab):
I guess there's something wrong in the color scheme we have right now? |
That should be doable I think. We will need to generate the color pallete for each service from the Material theme builder tool. More info. I was able to match the default (Youtube) colors in Compose using that tool in #12385 |


What is it?
Description of the changes in your PR
Before/After Screenshots/Screen Record
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence