Skip to content

Conversation

@dustdfg
Copy link
Contributor

@dustdfg dustdfg commented Jan 6, 2026

What is it?

  • Bugfix (user facing)

Description of the changes in your PR

Allow dragging boorkmarked playlist in both directions. Its code is Ctrl+C/Ctrl+V from newpipe/local/playlist/LocalPlaylistFragment. All necessary infrastructure was already present but just not used ¯\_(ツ)_/¯

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Jan 6, 2026
@TobiGr TobiGr added GUI Issue is related to the graphical user interface playlist Anything to do with playlists in the app labels Jan 6, 2026
@TobiGr
Copy link
Contributor

TobiGr commented Jan 6, 2026

thank you, lgtm, but please change the base branch to the release branch for 0.28.1

@dustdfg dustdfg changed the base branch from dev to release-0-28.1 January 6, 2026 07:59
Ctrl+C/Ctrl+V from newpipe/local/playlist/LocalPlaylistFragment
@dustdfg dustdfg force-pushed the playlist_normal_drag branch from a1fb7b7 to 9998d99 Compare January 6, 2026 08:03
@dustdfg
Copy link
Contributor Author

dustdfg commented Jan 6, 2026

thank you, lgtm, but please change the base branch to the release branch for 0.28.1

Can you please provide something like lambda for me that allows to understand which branch should be targeted?

@TobiGr
Copy link
Contributor

TobiGr commented Jan 6, 2026

I saw that the linked issue is in the 0.28.x project. I somehow assumed that the subversion was set to 0.28.1, which was initially true, but I moved in to 0.28.2 a few days ago. Since dev has already non-fix changes compered to when the release process was initiated, fixes for the relea should target the release branch. And that's where I messed up. You did everything correctly and targeted dev. But this is a simple fix which can be included in the new release easily.

Code looks good, test runners have problems to run the build

@TobiGr TobiGr merged commit 635e6a5 into TeamNewPipe:release-0-28.1 Jan 6, 2026
8 of 13 checks passed
@dustdfg dustdfg deleted the playlist_normal_drag branch January 6, 2026 19:51
@TobiGr TobiGr mentioned this pull request Jan 7, 2026
4 tasks
@dustdfg
Copy link
Contributor Author

dustdfg commented Jan 9, 2026

/backport dev ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GUI Issue is related to the graphical user interface playlist Anything to do with playlists in the app size/small PRs with less than 50 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Playlist sorting in grid view behaves incorrectly

2 participants