Skip to content

Conversation

@theimpulson
Copy link
Member

@theimpulson theimpulson commented Jan 7, 2026

What is it?

  • Bugfix (user facing)
  • Feature (user facing) ⚠️ Your PR must target the refactor branch
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Adds a new module net.newpipe.app to host new compose code
  • Introduces support for compose but with multi-platform support:
    • Supported targets include: Android, iOS and Desktop (Windows, MacOS, and Linux)
    • Android changes are packed into a library using the new library plugin and thus can be accessed by the existing module containing legacy code

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added the size/large PRs with less than 750 changed lines label Jan 7, 2026
@theimpulson
Copy link
Member Author

Most libraries are preferred from JetBrain's fork instead of Android for proper multi-platform support for the new compose and Kotlin code we will be introducing going forward.

@github-actions github-actions bot added size/medium PRs with less than 250 changed lines size/large PRs with less than 750 changed lines and removed size/large PRs with less than 750 changed lines size/medium PRs with less than 250 changed lines labels Jan 7, 2026
@absurdlylongusername
Copy link
Member

Shouldn't this target the refactor branch?

@theimpulson
Copy link
Member Author

Shouldn't this target the refactor branch?

refactor branch already has a different compose setup specific to android and is using navigation2 while navigation3 is now stable. I don't want to spend time on writing migration for it and thus decided to use dev as a base for a clean state while picking code which can be reused.

Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Strip out Android-specific implementation for handling black theme for now

Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Resolve deprecation errors and adjust code to make testing easier

Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
@Stypox
Copy link
Member

Stypox commented Jan 17, 2026

Cool, thanks! This ideally would go into refactor though. Can't you convert the refactor setup? Or is this supposed to be just a PoC to see if it would work and the actual conversion of the current refactor branch setup would be done once we see it's viable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/large PRs with less than 750 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants