Composify BaseDescriptionFragment and those who inherit from it#13288
Closed
dustdfg wants to merge 1 commit intoTeamNewPipe:refactorfrom
Closed
Composify BaseDescriptionFragment and those who inherit from it#13288dustdfg wants to merge 1 commit intoTeamNewPipe:refactorfrom
dustdfg wants to merge 1 commit intoTeamNewPipe:refactorfrom
Conversation
dustdfg
commented
Feb 25, 2026
Comment on lines
+211
to
+212
| val link = LinkAnnotation.Url( | ||
| image.url, |
Contributor
Author
There was a problem hiding this comment.
Original used here ShareUtils... If it matters
Contributor
Author
|
I am so stupid 🤦♀️ No one forces me to generate Metadata Just In Time. I can "generate" it a bit Ahead Of Time and just pass |
Contributor
Author
|
I didn't see #11489 🤦♀️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
refactorbranchDescription of the changes in your PR
Well probably it should be closed....
Introduced regressions/reasons to close
TextLinkifierported to use AnnotatedString)CommentsSectionbut it doesn't work)Introduced features
Before/After Screenshots/Screen Record
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence