Skip to content

Composify BaseDescriptionFragment and those who inherit from it#13288

Closed
dustdfg wants to merge 1 commit intoTeamNewPipe:refactorfrom
dustdfg:description_fragment_compose
Closed

Composify BaseDescriptionFragment and those who inherit from it#13288
dustdfg wants to merge 1 commit intoTeamNewPipe:refactorfrom
dustdfg:description_fragment_compose

Conversation

@dustdfg
Copy link
Contributor

@dustdfg dustdfg commented Feb 25, 2026

What is it?

  • Bugfix (user facing)
  • Feature (user facing) ⚠️ Your PR must target the refactor branch
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Composify BaseDescriptionFragment and those who inherit from it

Well probably it should be closed....

Introduced regressions/reasons to close

  1. Description now doesn't support hashtags and timestamps (temporarily till TextLinkifier ported to use AnnotatedString)
  2. Text contrast is lost (Too little colors to use (or I am just dumb probably both))
  3. Composables are not separated in separate files (half of them could be)
  4. Composables are members of the Fragment class
  5. COMPOSABLES ARE OVERRIDEN (perversion of the highest level, it looks quite elegant though)
  6. Scroll is lost (idk, I did everything like did in CommentsSection but it doesn't work)
  7. Previous thing was smart and centered tags when there was only one row and just pushed them to left when there are more than one line
  8. One big commit
  9. I can't remove any of those 8 points mentioned above

Introduced features

  1. Now you can select text in a channel info tab 🥳

Before/After Screenshots/Screen Record

  • Before:
20260225_01h51m20s_grim 20260225_01h51m37s_grim
  • After:
20260225_01h48m52s_grim 20260225_01h49m35s_grim

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added the size/giant PRs with more than 750 changed lines label Feb 25, 2026
Comment on lines +211 to +212
val link = LinkAnnotation.Url(
image.url,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original used here ShareUtils... If it matters

@dustdfg dustdfg marked this pull request as draft February 25, 2026 07:28
@dustdfg
Copy link
Contributor Author

dustdfg commented Feb 25, 2026

I am so stupid 🤦‍♀️ No one forces me to generate Metadata Just In Time. I can "generate" it a bit Ahead Of Time and just pass List<Pair<String,AnnotatedString>> for metadata. And remove all the bad points which are about code quality

@dustdfg
Copy link
Contributor Author

dustdfg commented Feb 26, 2026

I didn't see #11489 🤦‍♀️

@dustdfg dustdfg closed this Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/giant PRs with more than 750 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant