Add Tests for NewPlayer

[nicholasala]

Hello everybody

I am writing some tests for NewPlayer. I started from unit tests and then I can move on to UI tests. I write a list here with which classes are tested and which are supposed to be tested, then I will update this list. Feel free to suggest additions to the list.

Unit tests

• CachingRepository
• PrefetchingRepository
• NewPlayerImpl
• NewPlayerViewModelImpl

[theScrabi]

lgtm. Please squash your commits though.

[nicholasala]

Hi guys

I think we have reached a good initial point considering unit tests. We have now 83 unit tests and the priority classes to be tested are tested now. So I am about to move to UI tests and I was thinking to start with VideoPlayerControllerUI. Let me know if you have other ideas 😉

[Stypox]

@nicholasala do you want to continue on this branch, or would you prefer this PR to be merged, and then opening a separate PR?
Thank you a lot by the way!

I guess one of the most complex UI components to test is the guesture system. So maybe do that part after you tested other simpler stuff.

[nicholasala]

Thank you @Stypox! I would prefer to close this PR and open a new one dedicated to UI tests, so I am going to mark this PR as ready for review 👍

Perfect, I will follow your advice regarding the UI tests

[Stypox]

Thank you for working on the tests! Sorry for taking so long to merge

[nicholasala]

No problem! Thank you guys, I am glad to have made a contribution to the project. Considering UI tests I will ask @Profpatsch, that I know is working on the project if it is ok to proceed or it is better to wait.