Skip to content

audio ui: landscape: shift the title upwards#20

Merged
Stypox merged 4 commits intoTeamNewPipe:devfrom
crazo7924:audio-ui-shift-title
Feb 28, 2025
Merged

audio ui: landscape: shift the title upwards#20
Stypox merged 4 commits intoTeamNewPipe:devfrom
crazo7924:audio-ui-shift-title

Conversation

@crazo7924
Copy link
Contributor

It looks nicer IMHO

Preview as shown in the Design tab:

image

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Can you run this on a device/emulator and post screenshots both in landscape and portrait?

@Stypox
Copy link
Member

Stypox commented Feb 24, 2025

Oh, also, is there any other audio player interface we can compare this with? E.g. some other app.

@crazo7924
Copy link
Contributor Author

Oh, also, is there any other audio player interface we can compare this with? E.g. some other app.

YT Music, when in landscape mode, has the title on top and fills the cover artwork in the background has the controls sitting on top of it, very much like a video player.

Spotify seems to not have a big UI for audio controls and instead has the playlist covering a large portion of the screen.

@crazo7924
Copy link
Contributor Author

Having the list on the side seems like a good idea.

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some further adjustments and simplified the layout by removing a lot of Boxes that were there before this PR. Thank you!

P.S. next time you open a PR that does design changes, please post a table of screenshots before/after in landscape/portrait like I did below ;-)

Before After
Before After
Before After

@Stypox Stypox merged commit ff16f2c into TeamNewPipe:dev Feb 28, 2025
@crazo7924
Copy link
Contributor Author

P.S. next time you open a PR that does design changes, please post a table of screenshots before/after in landscape/portrait like I did below ;-)

I think this could go into a PR template

@Stypox
Copy link
Member

Stypox commented Feb 28, 2025

Yeah in NewPipe we have such a PR template. Could you copy it to this repo and open a PR to add it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments