audio ui: landscape: shift the title upwards#20
Conversation
It looks nicer IMHO
Stypox
left a comment
There was a problem hiding this comment.
Thank you! Can you run this on a device/emulator and post screenshots both in landscape and portrait?
new-player/src/main/java/net/newpipe/newplayer/ui/audioplayer/AudioPlayerUI.kt
Outdated
Show resolved
Hide resolved
new-player/src/main/java/net/newpipe/newplayer/ui/audioplayer/AudioPlayerUI.kt
Outdated
Show resolved
Hide resolved
|
Oh, also, is there any other audio player interface we can compare this with? E.g. some other app. |
YT Music, when in landscape mode, has the title on top and fills the cover artwork in the background has the controls sitting on top of it, very much like a video player. Spotify seems to not have a big UI for audio controls and instead has the playlist covering a large portion of the screen. |
|
Having the list on the side seems like a good idea. |
I think this could go into a PR template |
|
Yeah in NewPipe we have such a PR template. Could you copy it to this repo and open a PR to add it? |




It looks nicer IMHO
Preview as shown in the Design tab: