Fix ghost clicks on chapter and stream select

[lm41]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

This PR fixes ghost clicks (#3) on the chapter select box. The same logic can be applied to the stream select UI but I couldn't find a way to test the stream select UI so I left it out for now.

Fixes the following issue(s)

• Fixes Ghost taps in video player UI #3

Due diligence

• I read the contribution guidelines.

[ShareASmile]

Thanks for the PR. Keep them coming.

Next time please use "Fixes" keyword followed by Issue no. in your PR description to automatically link and close an associated issue when the pull request is merged.

If a previously unreported bug is found in the NewPlayer, please don't hesitate to create a new issue about that first. Thank you.

[lm41]

I didn't use the fixes keyword because this PR only partially fixes the problem. (Only in the chapter select but not in the stream select UI).
I'll have to check if I can use the same approach there as well.

[TobiGr]

Thank you. Changes LGTM, I just have a nitpick.
I also could not find a good way to test the stream select UI for this specific case. (We really need to set up proper testing...)

[lm41]

I think I found a way to test the StreamSelectUI in this specific use case:

1. Add multiple videos to the queue
2. Go to fullscreen mode
3. Click on the icon next to the three vertical dots.

The stream select UI is the queue UI. If it is not used anywhere else we should think about renaming it because stream select implies (at least for me), that multiple resolutions or audio streams can be selected with it.

[theScrabi]

I'm going to check this. :)

[theScrabi]

lgdm :)

[theScrabi]

@lm41 although this is only partly a fix, because now the tap is being ignored, which is better than before, but what I would actually expect as a user is for GuestureUI to react on the tap.
Can we make that work?

[Stypox]

@theScrabi I think it's fine to ignore taps while stuff is phasing in/out. However we should change the animation Easing so that it's clear when the animation is still running (something like SlowInFastOut, or even just linear).

[lm41]

@theScrabi I'm currently not at home but I'll have a look into that later next week

[lm41]

Can we make that work?

We possibly could, but that would probably mean that we would have to intercept touch events and pass them to the GestureUI.