Update OpenFIREcommon.cpp - assign OLED.display pointer to nullptr#135
Merged
SeongGino merged 1 commit intoTeamOpenFIRE:OpenFIRE-devfrom Nov 23, 2025
Merged
Conversation
By assigning the OLED.display pointer to nullptr, the program works and the micro doesn't crash, even if the OLED display is not connected even if the pins are configured.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By assigning the OLED.display pointer to nullptr, the program works and the micro doesn't crash, even if the OLED display is not connected even if the pins are configured.
...
This probably solves the problem you describe in OpenFIREdisplay.cpp on line 29 " // TODO: for some reason, doing this AFTER saving updated pins settings (even when doing it from defaults and there's no default mappings for peripheral pins)
// causes the board to hang. Even though this is all correct (and any display objects should get deleted from the above, so don't think it can be a new object thing)...
"