[feat and fix] Implement the remaining features and fix bugs for roll feature - #1684
Closed
Deepseasaltyfish wants to merge 11 commits into
Closed
[feat and fix] Implement the remaining features and fix bugs for roll feature#1684Deepseasaltyfish wants to merge 11 commits into
Deepseasaltyfish wants to merge 11 commits into
Conversation
* fix railHeight calculating * clean format (cherry picked from commit c3f7207)
fix VecUtil.fromYawRoll
…omething wrong with they planes
# Conflicts: # src/main/java/cam72cam/immersiverailroading/track/BuilderIterator.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related UMC PRs:
TeamOpenIndustry/UniversalModCore#258
TeamOpenIndustry/UniversalModCore#248
this PR is mainly about the rail block, we have better shapes to fit the track model, and snow logic is updated to fit this better, snowLayers now starts from bedHeights