Add support for feed pagination #583
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we limit the results per page to something like 20 or 30? With the current solution, LibreTube would need to implement a custom solution that would need to handle pagination internally too for each group of 20 or 30 videos because otherwise the performance and loading times would be very awful. So that'd be kind of duplicated pagination on LibreTube's side, which I don't think is a good idea. |
|
Yes, I think it would be feasible to add a limit parameter! |
FireMasterK
force-pushed
the
feed-pagination
branch
from
ac121aa to
ac0ffef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See TeamPiped/Piped#1046