Skip to content

feat(web): add course register sidepanel#90

Merged
chenxin-yan merged 18 commits intomainfrom
feat/sidepanel
Dec 11, 2025
Merged

feat(web): add course register sidepanel#90
chenxin-yan merged 18 commits intomainfrom
feat/sidepanel

Conversation

@xyspg
Copy link
Collaborator

@xyspg xyspg commented Nov 9, 2025

📌 What's Changed

add side panel and handle courses alternatives. Closes #67 and #79

✅ Actions

  • [ ]

📝 Notes for Reviewer

the state between components becomes complex. should we setup a state management library

CleanShot 2025-11-09 at 02 19 48@2x
CleanShot 2025-11-09 at 02 22 14@2x

@xyspg xyspg requested a review from chenxin-yan November 9, 2025 07:21
@chenxin-yan chenxin-yan marked this pull request as ready for review November 9, 2025 20:59
@chenxin-yan chenxin-yan self-assigned this Nov 11, 2025
@chenxin-yan chenxin-yan force-pushed the main branch 3 times, most recently from 551a188 to 78a92a9 Compare November 12, 2025 09:40
@chenxin-yan chenxin-yan changed the title feat(web): add sidepanel feat(web): add course register sidepanel Nov 13, 2025
Copy link
Member

@chenxin-yan chenxin-yan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things to address:

  • when user is trying to add a course that has a conflicting timeslot on calendar. Show a dialog to user to ask if want to add as alternative
  • when handling "add as alternative" it gave user all the userCourseOfferings to select. However, we only want to scope to that year. For example, if I am planning for spring 2026, when I do not want to see courses I had for fall 2025 shown when adding alternatives
  • If course A is an alternative of B, When B is deleted, A should be available. Currently, when B is deleted, A is also delete$
  • user should be switching between alternative courses easily. I should be clicking on an courses that is an alternative and replace that with that it was alternative of.

@xyspg xyspg requested a review from chenxin-yan December 1, 2025 15:21
Copy link
Member

@chenxin-yan chenxin-yan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great. I tested it locally and it works. I will look at the code later and clean things up if needed. The only thing is that, it seems to have performance issue with the side panel. Is it lagging when you use the seedling data?

@xyspg
Copy link
Collaborator Author

xyspg commented Dec 1, 2025

looks great. I tested it locally and it works. I will look at the code later and clean things up if needed. The only thing is that, it seems to have performance issue with the side panel. Is it lagging when you use the seedling data?

I will look into it. I was focusing on the interaction logic so I didn't notice the lag

@chenxin-yan chenxin-yan merged commit d916e95 into main Dec 11, 2025
2 checks passed
@chenxin-yan chenxin-yan deleted the feat/sidepanel branch December 11, 2025 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add course detail sidepanel

2 participants

Comments