feat(web): add course register sidepanel#90
Merged
chenxin-yan merged 18 commits intomainfrom Dec 11, 2025
Merged
Conversation
551a188 to
78a92a9
Compare
chenxin-yan
requested changes
Nov 13, 2025
Member
There was a problem hiding this comment.
A few things to address:
- when user is trying to add a course that has a conflicting timeslot on calendar. Show a dialog to user to ask if want to add as alternative
- when handling "add as alternative" it gave user all the userCourseOfferings to select. However, we only want to scope to that year. For example, if I am planning for spring 2026, when I do not want to see courses I had for fall 2025 shown when adding alternatives
- If course A is an alternative of B, When B is deleted, A should be available. Currently, when B is deleted, A is also delete$
- user should be switching between alternative courses easily. I should be clicking on an courses that is an alternative and replace that with that it was alternative of.
chenxin-yan
requested changes
Dec 1, 2025
Member
chenxin-yan
left a comment
There was a problem hiding this comment.
looks great. I tested it locally and it works. I will look at the code later and clean things up if needed. The only thing is that, it seems to have performance issue with the side panel. Is it lagging when you use the seedling data?
Collaborator
Author
I will look into it. I was focusing on the interaction logic so I didn't notice the lag |
e23fc18 to
317867e
Compare
317867e to
41f2d7b
Compare
chenxin-yan
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 What's Changed
add side panel and handle courses alternatives. Closes #67 and #79
✅ Actions
📝 Notes for Reviewer
the state between components becomes complex. should we setup a state management library