-
Notifications
You must be signed in to change notification settings - Fork 2k
[php/hyperf] Remove broken hyperf framework #10505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hyperf has been tagged as broken for 6 years. https://github.com/TechEmpower/FrameworkBenchmarks/blame/master/frameworks/PHP/hyperf/benchmark_config.json
|
Yes, is tagged as broken, but the framework is actively developed. I'll open a issue in their repo. |
joanhey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please leave the code.
|
Normally I remove frameworks, but first I check if the framework is still in active development. Happy new year !!! |
|
If it hasn't been fixed in 6 years, nobody seems to be interested in running it on TechEmpower? |
|
Please close the PR. Thank you !!! |
|
It is not close the fw that fail, we need to close the fw that are close, or near. |
|
The code is there and don't disturb the runs. |
|
One thing is mark as broken, and another delete the code that is already marked as broken. EDIT: even if don't exist, we can maintain the history !! |
Other broken implementations for maintained frameworks have been removed before.
The code is still present in git history. |
|
We could keep this open for a month to see if the benchmarks get fixed. |
Hyperf has been tagged as broken for 6 years.
https://github.com/TechEmpower/FrameworkBenchmarks/blame/master/frameworks/PHP/hyperf/benchmark_config.json