Skip to content

Conversation

@p8
Copy link
Contributor

@p8 p8 commented Jan 3, 2026

@joanhey
Copy link
Contributor

joanhey commented Jan 3, 2026

Yes, is tagged as broken, but the framework is actively developed.
So they have the code base for the bench.

I'll open a issue in their repo.

Copy link
Contributor

@joanhey joanhey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave the code.

@joanhey
Copy link
Contributor

joanhey commented Jan 3, 2026

Normally I remove frameworks, but first I check if the framework is still in active development.
Not if only fail in the benchmark.

Happy new year !!!

@p8
Copy link
Contributor Author

p8 commented Jan 3, 2026

If it hasn't been fixed in 6 years, nobody seems to be interested in running it on TechEmpower?
I'm ok with keeping this, if the hyperf community is interested in keeping it and fixing it.

@joanhey
Copy link
Contributor

joanhey commented Jan 3, 2026

Please close the PR.
With hhvm I said 👍 but not with this one.

Thank you !!!

@joanhey
Copy link
Contributor

joanhey commented Jan 3, 2026

It is not close the fw that fail, we need to close the fw that are close, or near.

@joanhey
Copy link
Contributor

joanhey commented Jan 3, 2026

The code is there and don't disturb the runs.

@joanhey
Copy link
Contributor

joanhey commented Jan 3, 2026

One thing is mark as broken, and another delete the code that is already marked as broken.

EDIT: even if don't exist, we can maintain the history !!

@p8
Copy link
Contributor Author

p8 commented Jan 4, 2026

Normally I remove frameworks, but first I check if the framework is still in active development.

Other broken implementations for maintained frameworks have been removed before.
For example Hanami and Oak are still in active development, but the broken tests have been removed:
798a139#diff-fcdadea505b498d0377dd4106c73a4fefcfcd77f8c31816f306a346184690c10

EDIT: even if don't exist, we can maintain the history !!

The code is still present in git history.
If it's still in active development the code could be outdated though.

@p8
Copy link
Contributor Author

p8 commented Jan 4, 2026

We could keep this open for a month to see if the benchmarks get fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants