Skip to content

Tio server #8659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 40 commits into from
Dec 25, 2024
Merged

Tio server #8659

merged 40 commits into from
Dec 25, 2024

Conversation

@litongjava
Copy link
Contributor

@litongjava litongjava commented Dec 20, 2023

Please see readme.md

@litongjava
Copy link
Contributor Author

litongjava commented Dec 20, 2023

All code has been completed and tested in the local environment, please review

@litongjava
Copy link
Contributor Author

litongjava commented Dec 22, 2023

All code has been completed and tested in the local environment, please review again

@litongjava
Copy link
Contributor Author

litongjava commented Dec 25, 2023

I've been submitting this for days, why is there no response?

@joanhey
Copy link
Contributor

joanhey commented May 22, 2024

This PR don't pass the tests.
You need to fix it to pass the tests before is merged.

@litongjava
Copy link
Contributor Author

litongjava commented May 25, 2024

removed,please check

@litongjava
Copy link
Contributor Author

litongjava commented Jun 25, 2024

please approval

@litongjava
Copy link
Contributor Author

litongjava commented Jul 21, 2024

fixed,please re-test

@litongjava
Copy link
Contributor Author

litongjava commented Jul 21, 2024

fixed all problems, please approval

@litongjava
Copy link
Contributor Author

litongjava commented Jul 23, 2024

@joanhey please approval

@litongjava litongjava requested a review from joanhey August 30, 2024 04:28
@litongjava
Copy link
Contributor Author

litongjava commented Sep 14, 2024

fixed,please check

@litongjava
Copy link
Contributor Author

litongjava commented Sep 25, 2024

I've finish this pr, it can be merged

@litongjava
Copy link
Contributor Author

litongjava commented Oct 29, 2024

@joanhey Hi! This PR has passed all checks and has no conflicts with the base branch. Could you please help review it? Thank you for your time!

joanhey
joanhey reviewed Oct 29, 2024
View reviewed changes
frameworks/Java/tio-http-server/tio-server.dockerfile Outdated
WORKDIR /app

COPY pom.xml pom.xml
RUN mvn dependency:go-offline
Copy link
Contributor

@joanhey joanhey Oct 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add --quiet
Now it's creating +5k useless and noisy lines in the logs.
Progress ....
https://github.com/TechEmpower/FrameworkBenchmarks/actions/runs/11042481015/job/30945138563#step:9:5723

Copy link
Contributor Author

@litongjava litongjava Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joanhey Thanks, I've fixed. Could you please help review it? Thank you for your time!

@litongjava
Copy link
Contributor Author

litongjava commented Nov 15, 2024

@joanhey Thanks, I've fixed. Could you please help review it? Thank you for your time!

@litongjava litongjava requested a review from joanhey November 29, 2024 23:22
@NateBrady23 NateBrady23 merged commit 0597580 into TechEmpower:master Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@joanhey joanhey joanhey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: Please Update

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@litongjava @joanhey @NateBrady23