Skip to content

[crystal/lucky] Fix tests and update dependencies #9380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2024
Merged

[crystal/lucky] Fix tests and update dependencies #9380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frameworks/Crystal/lucky/lucky.dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM crystallang/crystal:1.12.1
FROM crystallang/crystal:1.14.0

WORKDIR /lucky
COPY shard.lock shard.lock
Expand All @@ -14,7 +14,7 @@ ENV LUCKY_ENV production

RUN shards build bench --release --no-debug

ENV DATABASE_URL postgres://benchmarkdbuser:benchmarkdbpass@tfb-database:5432/hello_world?initial_pool_size=56&max_idle_pool_size=56
ENV DATABASE_URL postgres://benchmarkdbuser:benchmarkdbpass@tfb-database:5432/hello_world?initial_pool_size=10&max_idle_pool_size=10
Copy link
Contributor

@joanhey joanhey Nov 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, only an small question !!
All are playing with different pool sizes for the databases.

But we are learning (all languages) witch one is better ???

Copy link
Contributor

@joanhey joanhey Nov 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's only a question for reflexion !!
So we can learn all together.

Nothing about this PR.

PD: try to manage the pool size relative to the CPU cores, server, ... and not hardcoded.

Copy link
Contributor Author

@p8 p8 Nov 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem @joanhey 😄
I think the pool size is already per CPU core.
This was causing the runs to fail as it was making too many connections (new machine has more cores).


EXPOSE 8080

Expand Down
6 changes: 3 additions & 3 deletions frameworks/Crystal/lucky/shard.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ version: 2.0
shards:
avram:
git: https://github.com/luckyframework/avram.git
version: 1.2.0
version: 1.3.0

backtracer:
git: https://github.com/sija/backtracer.cr.git
Expand Down Expand Up @@ -30,7 +30,7 @@ shards:

habitat:
git: https://github.com/luckyframework/habitat.git
version: 0.4.8
version: 0.4.9

lucky:
git: https://github.com/luckyframework/lucky.git
Expand Down Expand Up @@ -66,7 +66,7 @@ shards:

splay_tree_map:
git: https://github.com/wyhaines/splay_tree_map.cr.git
version: 0.2.2
version: 0.3.0

wordsmith:
git: https://github.com/luckyframework/wordsmith.git
Expand Down
Loading