Skip to content

feat: add ultimate express #9390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Dec 13, 2024
Merged

feat: add ultimate express #9390

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
98c2a34
feat: add ultimate express
Pho3niX90 Nov 10, 2024
11e2bd7
feat: add ultimate express
Pho3niX90 Nov 10, 2024
d468cd8
refactor(express): simplify response handling by removing writeRespon…
Pho3niX90 Nov 10, 2024
16db140
fix: unique display names
Pho3niX90 Nov 10, 2024
96bba27
fix: names
Pho3niX90 Nov 10, 2024
b1ea37d
fix: add db/query/update/fortune urls
Pho3niX90 Nov 10, 2024
d45b608
fix: missing orm value
Pho3niX90 Nov 10, 2024
543092f
fixes
Pho3niX90 Nov 10, 2024
3017dc6
fixes
Pho3niX90 Nov 10, 2024
c752e2a
fixes
dimdenGD Nov 10, 2024
c89ade1
full refactor
dimdenGD Nov 10, 2024
fcdf324
fix etag and disable x-powered-by
dimdenGD Nov 10, 2024
4fcc1db
generate json dynamically
dimdenGD Nov 10, 2024
b9b29fa
fix space
dimdenGD Nov 10, 2024
8f5b177
use fjs
dimdenGD Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frameworks/JavaScript/ultimate-express/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { sjs, attr } from 'slow-json-stringify'
const { DATABASE } = process.env;
const db = DATABASE ? await import(`./database/${DATABASE}.js`) : null;

const jsonSerializer = sjs({ message: attr("string")});
const jsonSerializer = sjs({ message: attr("string") });
Copy link
Contributor

@nigrosimone nigrosimone Nov 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-json-steingify is faster than slow-json-stringify with "unsafe" string type https://www.npmjs.com/package/fast-json-stringify

Copy link
Contributor

@dimdenGD dimdenGD Nov 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find a benchmark for that

Copy link
Contributor

@nigrosimone nigrosimone Nov 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made it here https://stackblitz.com/edit/stackblitz-starters-rlrggo

slow-json-stringify: 13.105ms
fast-json-stringify: string: 0.86ms
fast-json-stringify: unfafe: 0.815ms
JSON.stringify: 0.86ms

for small json JSON.stringify is faster, slow-json-stringify is always slow. Side note "fast-json-stringify: unfafe" is raw fast-json-stringify with no special chars support on string (\n, \r, \t, ", \), Hello, World! no need escape.

Use JSON.stringify, this libraries (fast-json-stringify and slow-json-stringify) works better on complex/huge json

slow-json-stringify last update is 4 years ago (maybe is abbandoned)
fast-json-stringify is active and mantained fy Fastify team

The better option is send as raw/stringified string

app.get('/json', (req, res) => {
  res.setHeader('Server', 'UltimateExpress');
  res.setHeader('Content-Type', 'application/json');
  res.end('{"message":"Hello, World!"}');
});

Copy link
Contributor

@dimdenGD dimdenGD Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must serialize JSON in the request as per test rules. Your benchmark has a bug and doesnt serialize object properly, I fixed and tested it and it seems that fast-json-stringify is still fastest, so I switched it over.


const generateRandomNumber = () => Math.floor(Math.random() * maxRows) + 1;

Expand Down