Skip to content

Conversation

@jonathanhefner
Copy link
Contributor

This PR is based on top of #9505. I can rebase it if #9505 is merged first.

This adds benchmark tests for the Next.js framework.

@p8
Copy link
Contributor

p8 commented Jan 9, 2025

👋

@msmith-techempower
Copy link
Member

I wrote a response in that other PR about relaxing the Fortunes test - for now, I think the simplest solution would be to not include the Fortunes test in this implementation (as it would fail for now - you can just comment it out with a note that links to the other PR) so as to get NextJS into this round.

@jonathanhefner
Copy link
Contributor Author

jonathanhefner commented Jan 10, 2025

@msmith-techempower Alright, understood. I rebased, disabled the Fortunes test, and added a corresponding note in the README.

This adds benchmark tests for the Next.js framework.
@jonathanhefner
Copy link
Contributor Author

@msmith-techempower The Docker image was failing to build because it copies an empty directory that wasn't tracked by git. I've added a .keep file to the directory, so the build should work now.

@msmith-techempower msmith-techempower merged commit ce36b84 into TechEmpower:master Jan 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants