[FrankenPHP] Remove unnecessary file-exists checks. #9549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Issue explaining why this prevents unnecessary requests to the filesystem https://github.com/dunglas/frankenphp/pull/1311/files |
| # by using php instead of php_server | ||
| rewrite runtime.php | ||
| php { | ||
| root /symfony/public |
Member
There was a problem hiding this comment.
Did you mean to remove the @phpFiles stuff from here? You added it to the franken Caddyfile - seems weird to remove it from symfony.
Author
There was a problem hiding this comment.
Yes, the previous configuration will check for files, directory index files and general php files, which is unnecessary in this case (there is only 1 entry file).
Rewriting directly to the entryfile will remove all 'file exists' checks..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimizes FrankenPHP/Symfony/Laravel by deactivating the
file server/try fileschecks and forwarding directly to the PHP runtime (which is all we need in this case).