Skip to content

[nextjs] Enable Fortunes test #9620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2025
Merged

[nextjs] Enable Fortunes test #9620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions frameworks/TypeScript/nextjs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,21 +27,3 @@
[`app/updates/route.ts`]: ./app/updates/route.ts
[`app/plaintext/route.ts`]: ./app/plaintext/route.ts
[`app/cached-queries/route.ts`]: ./app/cached-queries/route.ts

## TODO

The Fortunes test is currently disabled because the benchmark expects exact HTML output — see [TechEmpower/FrameworkBenchmarks#9505](https://github.com/TechEmpower/FrameworkBenchmarks/pull/9505). After that issue is resolved, the Fortunes test can be re-enabled by applying the following diff:

```diff
--- a/frameworks/TypeScript/nextjs/benchmark_config.json
+++ b/frameworks/TypeScript/nextjs/benchmark_config.json
@@ -20,7 +20,7 @@
"json_url": "/json",
"db_url": "/db",
"query_url": "/queries?queries=",
- "TEMPORARILY DISABLED fortune_url": "/fortunes",
+ "fortune_url": "/fortunes",
"update_url": "/updates?queries=",
"plaintext_url": "/plaintext",
"cached_query_url": "/cached-queries?queries="
```
2 changes: 1 addition & 1 deletion frameworks/TypeScript/nextjs/benchmark_config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"json_url": "/json",
"db_url": "/db",
"query_url": "/queries?queries=",
"TEMPORARILY DISABLED fortune_url": "/fortunes",
"fortune_url": "/fortunes",
"update_url": "/updates?queries=",
"plaintext_url": "/plaintext",
"cached_query_url": "/cached-queries?queries="
Expand Down
Loading