Skip to content

Update ASP.NET Core metadata #9639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 17, 2025
Merged

Update ASP.NET Core metadata #9639

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a8166cb
Update ASP.NET metadata
sebastienros Mar 10, 2025
635c6b8
Fix typeos
sebastienros Mar 10, 2025
dbfce96
Remove updates for MVC
sebastienros Mar 10, 2025
d4dd5e0
Add maintainers to benchmark_config.json
sebastienros Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions frameworks/CSharp/aspnetcore/benchmark_config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"framework": "aspnetcore",
"maintainers": ["DamianEdwards", "sebastienros"],
"tests": [
{
"default": {
Expand All @@ -14,15 +15,15 @@
"approach": "Realistic",
"classification": "Platform",
"database": "Postgres",
"framework": "ASP.NET Core",
"framework": "ASP.NET Core [Platform]",
"language": "C#",
"orm": "Raw",
"platform": ".NET",
"flavor": "CoreCLR",
"webserver": "Kestrel",
"os": "Linux",
"database_os": "Linux",
"display_name": "ASP.NET Core [Platform, Pg]",
"display_name": "ASP.NET Core [Platform]",
"notes": ""
},
"aot": {
Expand All @@ -37,15 +38,15 @@
"approach": "Realistic",
"classification": "Platform",
"database": "Postgres",
"framework": "ASP.NET Core",
"framework": "ASP.NET Core [Platform]",
"language": "C#",
"orm": "Raw",
"platform": ".NET",
"flavor": "NativeAOT",
"webserver": "Kestrel",
"os": "Linux",
"database_os": "Linux",
"display_name": "ASP.NET Core [Platform, Pg, AOT]",
"display_name": "ASP.NET Core [Platform, AOT]",
"notes": ""
},
"minimal": {
Expand All @@ -67,7 +68,7 @@
"webserver": "Kestrel",
"os": "Linux",
"database_os": "Linux",
"display_name": "ASP.NET Core [Minimal APIs, Pg, Dapper]",
"display_name": "ASP.NET Core [Minimal APIs]",
"notes": "",
"versus": "aspnetcore"
Copy link
Contributor

@DamianEdwards DamianEdwards Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did we want to change the "versus" value to, so that it's compared to the platform test? What is this actually referring to now?

Copy link
Contributor Author

@sebastienros sebastienros Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

versus: The name of another test

In this case it's the framework value concatenated with the name of the test: [default], minimal, mvc, aot. So to compare to Platform (which is default) we just use the framework name -> aspnetcore.

Copy link
Contributor

@DamianEdwards DamianEdwards Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the framework name was ASP.NET Core now?

Copy link
Contributor Author

@sebastienros sebastienros Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but there are two framework fields in the json ... I was referring to the top property (assuming that's what the doc describes) https://github.com/TechEmpower/FrameworkBenchmarks/wiki/Codebase-Framework-Files#benchmark-config-file

Copy link
Contributor Author

@sebastienros sebastienros Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one in each "test":

framework (metadata): name of the framework (only used to display information on the results site)

this one is display-only

Copy link
Contributor

@DamianEdwards DamianEdwards Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok so the actual framework name is "aspnetcore" and the display name is "ASP.NET Core"?

Copy link
Contributor Author

@sebastienros sebastienros Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok so the actual framework name is "aspnetcore" and the display name is "ASP.NET Core"?

Nothing after this change will display only "ASP.NET Core". There will always be [{test name}] at least.

Going back to your original question, putting aspnetcore in the versus properties means that we are comparing to the Platform test, since it's the default test. If we wanted to compare to MVC for instance we would have to use the value aspentcore-mvc.

Copy link
Contributor

@DamianEdwards DamianEdwards Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing after this change will display only "ASP.NET Core".

Right, but the filters panel will show the frameworks as "ASP.NET Core [Platform]", etc. yes? What is the "aspnetcore" value used for then I wonder?

Copy link
Contributor Author

@sebastienros sebastienros Mar 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the filters will show "ASP.NET Core [Platform]" now.

What is the "aspnetcore" value used for then I wonder?

I would assume only technical things like the versus property, or the tooling. But I am wondering how aspnetcore is even showing today then. Maybe I need to update the config.toml file too. Not sure what is the source of truth between these two.

Copy link
Member

@msmith-techempower msmith-techempower Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config.toml is in limbo atm - it's safe to ignore.

},
Expand All @@ -89,7 +90,7 @@
"webserver": "Kestrel",
"os": "Linux",
"database_os": "Linux",
"display_name": "ASP.NET Core [MVC, Pg, EF]",
"display_name": "ASP.NET Core [MVC]",
"notes": "",
"versus": "aspnetcore"
},
Expand All @@ -103,16 +104,17 @@
"approach": "Realistic",
"classification": "Platform",
"database": "MySQL",
"framework": "ASP.NET Core",
"framework": "ASP.NET Core [Platform]",
"language": "C#",
"orm": "Raw",
"platform": ".NET",
"flavor": "CoreCLR",
"webserver": "Kestrel",
"os": "Linux",
"database_os": "Linux",
"display_name": "ASP.NET Core [Platform, My]",
"notes": ""
"display_name": "ASP.NET Core [Platform, MySQL]",
"notes": "",
"versus": "aspnetcore"
}
}
]
Expand Down
Loading