Skip to content

php/spiral: cleanup #9682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 24, 2025
Merged

php/spiral: cleanup #9682

merged 7 commits into from
Mar 24, 2025

Conversation

@roxblnfk
Copy link
Contributor

@roxblnfk roxblnfk commented Mar 17, 2025 •
edited
Loading

  • enabled ORM Schema cache
  • disabled unused modules
  • fixed compatibility with PHP 8.4

@joanhey
Copy link
Contributor

joanhey commented Mar 19, 2025

Please update also to PHP8.4

@roxblnfk
Copy link
Contributor Author

roxblnfk commented Mar 20, 2025 •
edited
Loading

Is it possible to get output from this?
I can't reproduce this locally

spiral: Exception: The command '/bin/sh -c php app.php configure > /dev/null 2>&1' returned a non-zero code: 255

@joanhey
Copy link
Contributor

joanhey commented Mar 20, 2025

Change
php app.php configure > /dev/null 2>&1

to
php app.php configure

to see the output.

@msmith-techempower msmith-techempower mentioned this pull request Mar 24, 2025
Closed
@msmith-techempower
Copy link
Member

msmith-techempower commented Mar 24, 2025

This only failed due to a bug in the verifier (see #9724). LGTM!

@msmith-techempower msmith-techempower merged commit 1c894c9 into TechEmpower:master Mar 24, 2025
2 of 3 checks passed
@roxblnfk roxblnfk deleted the spiral-orm-config branch March 24, 2025 17:30
msmith-techempower added a commit that referenced this pull request Mar 24, 2025
@msmith-techempower
Update CICD logic
b83274f 
Attempts to address #9682
@msmith-techempower msmith-techempower mentioned this pull request Mar 24, 2025
Merged
msmith-techempower added a commit that referenced this pull request Mar 25, 2025
@msmith-techempower
Update CICD logic (#9725)
ff6a8a7 
* Update CICD logic

Attempts to address #9682

* Check Spiral

* [ci fw-only PHP/spiral] Attempt this again

* [ci fw-only PHP/spiral] Correct the CICD logic

* [ci fw-only PHP/spiral] Correct the CICD logic

* [ci fw-only PHP/spiral] Add logging

* [ci fw-only PHP/spiral] Add env var to dockerfile

* [ci fw-only PHP/spiral] Pass through to Docker

* [ci fw-only PHP/spiral] Maybe this is less dumb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@roxblnfk @joanhey @msmith-techempower