Aiohttp: Add pypy3 and minor optimisation #9903
Conversation
Dreamsorcerer
changed the title
| @@ -1,14 +1,14 @@ | |||
| FROM python:3.13 | |||
| FROM python:latest | |||
There was a problem hiding this comment.
FROM python:3 it's better.
If python use SEM versioning is not problem.
But latest is NOT so !!!
If you will be here for some years, and fix the problems it's OK, but now this line create a problem in the future.
Thank you !!
There was a problem hiding this comment.
I'm not sure it'll make any difference. Any changes for a v4 are no more likely to break the small amount of code here than a minor release would. Ideally we'd be able to have Dependabot bump the pinned version automatically...
There was a problem hiding this comment.
I think I'm okay with going with latest and if it breaks something we'll see it pretty plainly.
There was a problem hiding this comment.
Actually, thinking on this for more than one second, it would make it harder for people to understand what version was run on any given continuous benchmark run from day to day. Imagine some breaking change from 3.13 to 3.14 (as a contrived example) but this dockerfile says latest - might be hard without some guesswork what's going on. Agreeing with @joanhey that this should be returned to sem. ver.
| @@ -1,14 +1,14 @@ | |||
| FROM python:3.13 | |||
| FROM python:latest | |||
There was a problem hiding this comment.
I think I'm okay with going with latest and if it breaks something we'll see it pretty plainly.
| @@ -1,14 +1,14 @@ | |||
| FROM python:3.13 | |||
| FROM python:latest | |||
There was a problem hiding this comment.
Actually, thinking on this for more than one second, it would make it harder for people to understand what version was run on any given continuous benchmark run from day to day. Imagine some breaking change from 3.13 to 3.14 (as a contrived example) but this dockerfile says latest - might be hard without some guesswork what's going on. Agreeing with @joanhey that this should be returned to sem. ver.
I'd assume that would be visible in the logs somewhere...
Well, that suggestion was actually to use I don't mind too much either way though. |
* Aiohttp: minor optimisation * Create aiohttp-pypy.dockerfile * Update benchmark_config.json * Update config.toml * Update aiohttp-pypy.dockerfile * Update aiohttp-gunicorn.dockerfile * Update aiohttp-nginx.dockerfile * Update aiohttp-orm.dockerfile * Update aiohttp.dockerfile * Update requirements.txt * Create requirements-cpython.txt * Update aiohttp-gunicorn.dockerfile * Update aiohttp-nginx.dockerfile * Update aiohttp-orm.dockerfile * Update aiohttp.dockerfile * Update views.py * Update aiohttp-nginx.dockerfile * Update aiohttp-orm.dockerfile * Update aiohttp-pypy.dockerfile * Update aiohttp.dockerfile * Update requirements.txt * Update requirements-cpython.txt * Update app.py * Update config.toml * Update main.py * Update requirements.txt * Update requirements-cpython.txt * Update main.py * Update server.py * Update benchmark_config.json * Update aiohttp-gunicorn.dockerfile * Update aiohttp-nginx.dockerfile * Update aiohttp-orm.dockerfile * Update aiohttp-pypy.dockerfile * Update aiohttp.dockerfile * Update requirements-cpython.txt * Update aiohttp-gunicorn.dockerfile * Update aiohttp-nginx.dockerfile * Update aiohttp-orm.dockerfile * Update aiohttp-pypy.dockerfile * Update aiohttp.dockerfile * Update aiohttp-pypy.dockerfile
3 participants
I've also switched docker images to use the latest tag, so these don't need to be updated in future. Plus some other cleanup to reduce maintenance.