Skip to content

(Laravel) - force updating to a new number #9915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 30, 2025
Merged

(Laravel) - force updating to a new number #9915

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
318319d
Update Controller.php
cosmastech May 27, 2025
ad5b781
Merge branch 'TechEmpower:master' into patch-1
cosmastech May 29, 2025
f14e683
ensure random int is valid
cosmastech May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frameworks/PHP/laravel/app/Http/Controllers/Controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public function updates($queries = 1)

while ($queries--) {
$row = World::query()->find(self::randomInt());
$row->randomNumber = self::randomInt();
$row->randomNumber = ($randomInt = self::randomInt()) !== $row->randomNumber ? $randomInt : $randomInt + 1;
Copy link
Contributor

@p8 p8 May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If $randomInt is 10000 this would fail, as 10001 is invalid.
Other frameworks generate a new random number instead.

Copy link
Contributor Author

@cosmastech cosmastech May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! was not aware of that requirement. I've updated the method accordingly.

$row->save();

$rows[] = $row;
Expand Down