Open
Conversation
|
Good job! Does exactly what it's supposed to do and human friendly error messages. Super 😁 |
ibhf13
reviewed
Dec 29, 2025
| `Oops! ${response.status} (${response.statusText})` | ||
| ); | ||
| } | ||
| const data = await response.json(); |
Contributor
There was a problem hiding this comment.
check for unexpected data formats, here we expect strings
Suggested change
| const data = await response.json(); | |
| if (typeof data?.setup !== "string" || typeof data?.punchline !== "string") { | |
| throw new Error("Unexpected data format from API"); | |
| } |
There was a problem hiding this comment.
fair point, but this level of validation or defensive programming is not necessary for learning goals at this point
Contributor
|
great job 💪 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.