completed funny bones backend assignment#5
Open
AbdallahOdeh2006 wants to merge 1 commit intoTechLabs-Dusseldorf:mainfrom
Open
completed funny bones backend assignment#5AbdallahOdeh2006 wants to merge 1 commit intoTechLabs-Dusseldorf:mainfrom
AbdallahOdeh2006 wants to merge 1 commit intoTechLabs-Dusseldorf:mainfrom
Conversation
Author
|
Assignment completed! Ready for review. |
Contributor
|
great job 💪 |
ibhf13
reviewed
Dec 29, 2025
Comment on lines
+15
to
+17
| if (!joke.setup || !joke.punchline) { | ||
| throw new Error('Invalid joke data'); | ||
| } |
Contributor
There was a problem hiding this comment.
Ensure strings, not just “truthy”
Suggested change
| if (!joke.setup || !joke.punchline) { | |
| throw new Error('Invalid joke data'); | |
| } | |
| if (typeof data?.setup !== "string" || typeof data?.punchline !== "string") { | |
| throw new Error("Unexpected data format from API"); | |
| } |
There was a problem hiding this comment.
fair point, but the data format refers to the structure and the expected fields of the response and not type validation :) So for this level of learning, not necessary I'd say
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.