Skip to content

solving 2nd assignment #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TNxRebel wants to merge 1 commit into
base: main
Choose a base branch
from
Open

solving 2nd assignment #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions Funny-Bones/fetch-joke.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
async function main() {
try {
const response = await fetch("https://official-joke-api.appspot.com/random_joke");
const data = await response.json();
Copy link
Contributor

@ibhf13 ibhf13 Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would also handle “failed responses” (HTTP status not OK)

if (!response.ok) {
throw new Error(HTTP ${response.status} ${response.statusText});
}

Copy link
Contributor

@ibhf13 ibhf13 Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also didnt check for data format

if (typeof data?.setup !== "string" || typeof data?.punchline !== "string") {
throw new Error("Unexpected data format from API");
}

console.log(data.setup);
console.log(data.punchline);
} catch (error) {
console.error("Error: No Jokes for now.", error.message);
}
}
// console.log("1"); //to test the asynchronous behavior
main();
/*console.log("2"); //to test the asynchronous behavior
console.log("3"); //to test the asynchronous behavior
console.log("4"); //to test the asynchronous behavior
console.log("5");*/ //to test the asynchronous behavior
13 changes: 13 additions & 0 deletions Funny-Bones/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
"name": "funny-bones",
"version": "1.0.0",
"description": "",
"main": "index.js",
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1"
},
"keywords": [],
"author": "",
"license": "ISC",
"type": "commonjs"
}