Saras project-buisiness-site by SaraEnderborg · Pull Request #60 · Technigo/js-project-business-site

SaraEnderborg · 2025-09-17T13:54:28Z

Here is the link to my project:)
https://meek-entremet-8e1086.netlify.app/

sandrahagevall

Great job with your business site! It looks really good, clean and professional. I think both the HTML and CSS are well-structured and it's easy to follow along with your code. I really like how the images in the portfolio grid subtly pop up on hover—it adds a nice interactive touch. Overall, the whole site looks really calm and inviting. This is absolutely something your photographer-friend could use in real life :)

Once again, good job! You should be really proud of what you've achieved with your site :)

sandrahagevall · 2025-09-18T13:50:00Z

index.html

+              id="message"
+              rows="5"
+              cols="50"
+              placeholder="Let´s talk-what´s you´re vision?"


In the textarea placeholder ("Let´s talk-what´s you´re vision?"), you use a backtick instead of apostrophe, could replace it with apostrophe for better readability ("Let's talk – what's your vision?")

sandrahagevall · 2025-09-18T14:05:32Z

style.css

+@media (min-width: 600px) {
+  .grid {
+    grid-template-columns: repeat(3, 1fr);
+  }
+}
+
+@media (min-width: 1024px) {
+  .grid {
+    grid-template-columns: repeat(3, 1fr);
+  }
+}


You have the same code for media query min-width: 600px and min-width: 1024px, you can remove the media query for min-width: 1024px, since no more changes will happen when reaching 1024px.

sandrahagevall · 2025-09-18T14:16:11Z

index.html

+    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
+    <title>Photography by Louise</title>
+    <link 
+      href="https://fonts.googleapis.com/css2?family=Great+Vibes&family=Lato:wght@400;700&display=swap" rel="stylesheet">


I guess you have forgotten to add this font link to the portfolio.html, so when you go to the portfolio-side, the h1 (Photography by Louise) have another font.

sandrahagevall · 2025-09-18T14:18:44Z

style.css

+  font-weight: bold;
+  letter-spacing: 1px;
+  position: relative;
+  transition: all 0.3 ease;


Missing a "s" for seconds (all 0.3s ease;)

sandrahagevall · 2025-09-18T14:24:09Z

index.html

+              alt="wedding-beach"
+            />
+            <h3>Wedding</h3>
+            <p>Romantic pictures from you´re big day.</p>


Typo: Should be "Romantic pictures from your big day"

sandrahagevall · 2025-09-18T14:25:57Z

index.html

+          action="http://httpbin.org/anything"
+          method="POST"
+        >
+          <div class="formt-input">


Typo: "formt-input", I guess it should be "form-input". So for now the "Name" textfield in the form doesn't have the same spacing as "type of session", "preffered date" etc.

sandrahagevall · 2025-09-18T14:50:16Z

index.html

+              alt="Couple-photo"
+            />
+            <h3>Couples</h3>
+            <p>Capture love and you´re special moments</p>


Typo: Should be ".. your special moments"

Thank you Sandra:) fixed everything now i think.

HIPPIEKICK

Make sure your project looks good from 320px width and up. Right now you have some content that are wider than this which makes it look broken on small phones. Also the hamburger menu is kind of crashing with the heading.

Nice use of flexbox of CSS Grid!

PS. I will approve this as a hero image but for future reference, a hero image usually covers the whole page horizontally (no padding/margin on the sides).

Change request

Fix responsiveness so that everything fits on mobile
Make the hamburger menu readable

HIPPIEKICK · 2025-09-24T09:11:49Z

index.html

+      >
+        <h2>Make a request</h2>
+        <form
+          action="http://httpbin.org/anything"


Make sure to use the https method, as some browser will otherwise block this action

This is now fixed:)

HIPPIEKICK · 2025-09-24T09:29:58Z

script.js

+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+


One empty line is enough 😉

SaraEnderborg

changes requested are now fixed:)

SaraEnderborg · 2025-09-25T19:59:37Z

Hi! Not sure if this is where i reply but i have also commented in github and the changes requested are now fixed:) Thanks for the feedback.

________________________________ Från: Matilda Brunemalm ***@***.***> Skickat: den 24 september 2025 11:47 Till: Technigo/js-project-business-site ***@***.***> Kopia: Sara Enderborg ***@***.***>; Author ***@***.***> Ämne: Re: [Technigo/js-project-business-site] Saras project-buisiness-site (PR #60) @HIPPIEKICK requested changes on this pull request. Make sure your project looks good from 320px width and up. Right now you have some content that are wider than this which makes it look broken on small phones. Also the hamburger menu is kind of crashing with the heading. Nice use of flexbox of CSS Grid! PS. I will approve this as a hero image but for future reference, a hero image usually covers the whole page horizontally (no padding/margin on the sides). Change request * Fix responsiveness so that everything fits on mobile * Make the hamburger menu readable

________________________________ In index.html<#60 (comment)>:

+ src="../images/kid1.jpg"

+ alt="Family/Children-photo" + /> + <h3>Family/Children</h3> + <p>Natural and playful portraits of family/children</p> + </article> + </section> + </main> + + <section + id="contact" + class="contact" + > + <h2>Make a request</h2> + <form + action="http://httpbin.org/anything" Make sure to use the https method, as some browser will otherwise block this action

________________________________ In script.js<#60 (comment)>:

+

+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + One empty line is enough 😉 — Reply to this email directly, view it on GitHub<#60 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BWLQHO6ZLL5QM2NETQT7MUL3UJSCDAVCNFSM6AAAAACGYLZ7EKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTENRRHE2TKMZYGU>. You are receiving this because you authored the thread.Message ID: ***@***.***>

HIPPIEKICK

Great improvements!

SaraEnderborg added 10 commits September 5, 2025 12:00

Initial commit

4356cf8

update image path

0f6d506

changes image, css fixes

7309084

this commit will add the form

0567ea0

added hero button and responsive hero

644ba5f

this commit will add portfolio index+styling

489c48a

delited index folder

112277c

this commit added images to portfolio

509f0d0

this commit changed fonts for logo and body

7bcb197

html files moved from folder

97009bf

sandrahagevall reviewed Sep 18, 2025

View reviewed changes

SaraEnderborg added 2 commits September 19, 2025 16:17

This commit added hamburger menu and changed button styling

2eae268

This commit fixed typos and coding faults

ef47bc6

HIPPIEKICK requested changes Sep 24, 2025

View reviewed changes

SaraEnderborg added 2 commits September 25, 2025 21:30

This commit changed the hamburger menu and mediaqueries

95e60da

this commit changed to https method and cleaned js

092cb89

SaraEnderborg commented Sep 25, 2025

View reviewed changes

SaraEnderborg requested a review from HIPPIEKICK October 11, 2025 18:08

HIPPIEKICK approved these changes Oct 16, 2025

View reviewed changes

Conversation

SaraEnderborg commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sandrahagevall left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HIPPIEKICK left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SaraEnderborg left a comment

Choose a reason for hiding this comment

Uh oh!

SaraEnderborg commented Sep 25, 2025 via email

Uh oh!

HIPPIEKICK left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

SaraEnderborg commented Sep 17, 2025 •

edited

Loading