Business-site project Marina Lendt#69
Business-site project Marina Lendt#69marinalendt-png wants to merge 16 commits intoTechnigo:mainfrom
Conversation
HIPPIEKICK
left a comment
HIPPIEKICK
left a comment
There was a problem hiding this comment.
What a cute design! Not that I’m a designer but I’d probably go with some more padding in the text cards 😇
Well done implementing CSS Grid and Flexbox! Just make sure your hamburger menu is closable.
Change request
- Make sure hamburger menu is closable on small phones
| <li><a href="#">Home</a></li> | ||
| <li><a href="#">Our history</a></li> | ||
| <li><a href="#">Find us</a></li> | ||
| <li><a href="#">Contact</a></li> |
There was a problem hiding this comment.
I can´t change this? When I redo it, VSC saves this version. Am I doing anything wrong?
| <label class="radiobutton-container"> | ||
| <input type="radio" name="answer"> | ||
| <span class="custom-radio"></span> | ||
| <span>I accept that my information is being stored.</span> | ||
| </label> |
There was a problem hiding this comment.
This is not the most common input type for asking for acceptance. Radio buttons are used when the user should pick one of multiple options. When you only have one radio button it's impossible to "uncheck" it. I think you'd be better of with a checkbox in this case 😊
There was a problem hiding this comment.
Ofcourse! Silly me 😉 Should I change this now or just think about for next time?
|
Thank you for the input Matilda! Now the hamburger SHOULD work 🥳 |
3 participants
https://breadrevolt.netlify.app/