Skip to content

Arta and Iris js-project-movies-artaris#41

Open
irisdgz wants to merge 21 commits intoTechnigo:mainfrom
irisdgz:main
Open

Arta and Iris js-project-movies-artaris#41
irisdgz wants to merge 21 commits intoTechnigo:mainfrom
irisdgz:main

Conversation

@irisdgz
Copy link
Copy Markdown

@irisdgz irisdgz commented Dec 18, 2025

Please include your Netlify link here.
https://movieprojectartaris.netlify.app/

@irisdgz irisdgz changed the title js-project-movies-artaris Arta and Iris js-project-movies-artaris Dec 19, 2025
@Npahlfer
Copy link
Copy Markdown

Good job and nice use of React Router routes and linking!
When fetching data and handling loading states, try to make use of finally. That way you don't have to set the loading state to false both in your last .then() and in the .catch().
Make sure to keep reused URLs like the API URL in one place, as a constant, so it's easy to change and kept central when used in more than one file. The same goes for the API key, that could even be put in a .env file :)
The not found page doesn't seem to work, nor does navigating to a movie with a wrong ID, it falls back to Netlify's not found page. I can see that you've tried to add it as a fallback route with React Router, so worth looking into what's going wrong there.
Don't forget that the styled component theme exists, where you can put media queries and colors!
Would have wanted to see some more stretch goals to reach a higher grade, but overall nice work both of you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants