Skip to content

Hand in Mikaela and Emil webfall25#53

Open
mikaelasturk wants to merge 12 commits intoTechnigo:mainfrom
mikaelasturk:main
Open

Hand in Mikaela and Emil webfall25#53
mikaelasturk wants to merge 12 commits intoTechnigo:mainfrom
mikaelasturk:main

Conversation

@mikaelasturk
Copy link
Copy Markdown

👉 Live demo

Group project with Emil Florén and Mikaela Sturk

Copy link
Copy Markdown

@Npahlfer Npahlfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see that you guys utilize a Layout and the Outlet from React Router! Good usage of the styled component props, and great that you make use of finally for the try/catch and only setting the loading state to false once.

Make sure to keep reused URLs like the API URL in one place, as a constant, so it's easy to change and kept central when used in more than one file. The same goes for the API key, that could even be put in a .env file.

When naming components, think of what it is and what it symbolizes. I'm thinking of the icon that you export from the ui directory: Svg. It may be an SVG, but it's better to name it something descriptive like Arrow or BackArrow instead of just Svg :)

Nice to see that you guys have made use of the styled component theme file. But make sure to use it everywhere, at the moment you have used the breakpoints from the theme in some places and in other places not. The same goes for the colors. Try to be consistent there.

Overall good job guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants