Open
Conversation
HIPPIEKICK
previously requested changes
Sep 4, 2024
Contributor
HIPPIEKICK
left a comment
There was a problem hiding this comment.
Hi Erika, great job on your business site project! I would love to visit Scotland (by train though 🚂 😉).
HTML
- Your HTML is well-structured with clear sections for the header, main content, and form ⭐
- Your form is well-structured and clean as well, apart from the radio buttons. The value should be different for each input (as you've already written it), but the name needs to be the same for each input so that it's interpreted as a group. In your form now, it's possible to check all of the months, which is not the point with radio buttons.
- Keep the CSS to the CSS file, i.e. use CSS instead of the
<br>tag
CSS
- The design looks clean! The consistent use of padding, margins, and a unified color scheme contributes to this. One thing I would suggest you to improve is the readability of the text on your hero image, as the contrast is not so strong.
Changes requested
- Group the radio buttons properly
Overall, you’ve done a really good job with this project. You've nailed the responsive design and included the necessary form elements. Just a few adjustments, such as grouping the radio buttons properly is needed. Keep up the good work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.