Shanti Studio | UX collab | Week 12 | Eliane - #54
Open
El1an3 wants to merge 55 commits into
Open
Conversation
NellaMori
approved these changes
May 2, 2024
NellaMori
left a comment
NellaMori
left a comment
There was a problem hiding this comment.
Hello Eliane, and big congrats on finishing this project all alone ✨ You worried about it not to be perfect, well you got really close to that, and in 1 week on your own..super impressive! The site looks very close to the design and followed our requirements. How did you like Styled Components? Seems like you tackled it in the right way and implemented a great result! How cool you created a carousel using an external library! Now the design is not pixel perfect, but that's okay, here's a little things that can be taken into consideration to improve it even further if you want:
- use always format.svg for images not.jpg, this will ensure HQ on any screen size
- footer: divs are not centre aligned. You can easily add “margin: auto” to have the text vertically entered inside the div
- elements within a flex-box, to center-align them just add: `align-items: center;
You nailed it, kudos!! ⭐ 👑 💯
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Netlify link
https://shanti-studio.netlify.app/
Collaborators
none