Karate Girl App - #55
Open
FridaMari wants to merge 80 commits into
Open
Conversation
…ts folder and imported logo and social icons.
Added fonts.
Footer styling
Added margins on tablet.
Hero styling
Added missing alt-tags on images for accessibility.
Changed order on headings for accesibility.
…reen size in tailwind config
Updated readme and cleaned up code.
NellaMori
approved these changes
May 3, 2024
There was a problem hiding this comment.
Hello Frida & Johanna, congratulations for completing your week 12 project. It looks so neat! 🌷 The site looks very close to the design and followed our requirements. How did you like Tailwind? Seems like you tackled it in the right way and implemented a great result! Now the design is not pixel perfect, but that's okay, here's a little things that can be taken into consideration to improve it even further:
- use svg for all icons and images if available in the design (register now buttons for example), this will ensure HQ on any screen size
- icon sizes not always matching with the design
- hover and after click effect missing
- accessibility: you scored 90 would be best 95
Fix these little things and you're clear! 🚀 💯
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Netlify link
https://karategirl.netlify.app/
Collaborators
[JohannaBN]