Open
Conversation
JennieDalgren
approved these changes
Aug 27, 2024
Collaborator
JennieDalgren
left a comment
There was a problem hiding this comment.
Great job with your News Project!
Here are some feedback:
Responsive Typography and Images:
If you want to improve, even if we havent talked about this that much yet. Try to use relative units (like em, rem, or %) for font sizes and image widths rather than fixed px values. This ensures a smoother experience on various screen sizes.
Example:
h1 {
font-size: 2rem; /* Scales better with screen size */
}
img {
width: 100%; /* Makes images responsive */
}
HTML Structure:
Excellent choice of semantic elements like <header>, <main>, and <article>. One suggestion is to make sure that you have only one <h1> per page to maintain a clear hierarchy.
Example:
<h1>Main News Headline</h1> <!-- Keep only one h1 per page -->
Great work so far! Keep going, and these small tweaks will make your site even better. 👏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
link: https://master--bejewelled-bubblegum-a74c42.netlify.app/