Week 2: Project New site#539
Open
jacquelinekellyhunt wants to merge 10 commits intoTechnigo:masterfrom
Open
Conversation
JennieDalgren
approved these changes
Sep 6, 2024
Collaborator
JennieDalgren
left a comment
JennieDalgren
left a comment
There was a problem hiding this comment.
Great job with the project!
Nice job with the hamburger menu and the nice animation to go from hamburger to cross. However, it looks a bit broken on small mobiles.
There is too much padding on the grid when in mobile size and also on the tablet size. Try to use as much of the screen that you can!
See the difference here:
And then with that huge padding:
I will approve this project but at least make sure to change so that the hamburger menu doesnt look broken on smallest screens
Keep up the good work! (Also love the surf theme 🏄🏼♀️)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's my PR for the Project "News Site"
https://oceanbreaks.netlify.app/