Accessibility project- news site, collaboration with Fanny Henriques#541
Open
Anna2024WebDev wants to merge 25 commits intoTechnigo:masterfrom
Open
Accessibility project- news site, collaboration with Fanny Henriques#541Anna2024WebDev wants to merge 25 commits intoTechnigo:masterfrom
Anna2024WebDev wants to merge 25 commits intoTechnigo:masterfrom
Conversation
Changed footer name
Changed media queries
…increase contrast ratio
HIPPIEKICK
approved these changes
Oct 8, 2024
Contributor
HIPPIEKICK
left a comment
HIPPIEKICK
left a comment
There was a problem hiding this comment.
You’ve added alt tags to all your images, and your links all have descriptive text too ⭐️ The use of aria-label and visually-hidden classes for additional context is good and clever! However, what’s the reason of having a button inside an anchor tag? 👀 Your semantic HTML elements also improves the accessibility. It’s keyboard navigable and the contrasts are all good as well. Keep up the good work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View the page here; https://project-news-site-a11y--thesweetscoop.netlify.app/
GitHub: Anna2024WebDev
GitHub: Fannyhenriques