Skip to content

Conversation

@sherif-olaboye
Copy link
Contributor

JIRA link

https://hee-tis.atlassian.net/browse/TD-4383

Description

I added a new button that only show if the delegate has admin role
I added confirmation page showing a list of centre admin roles and radio buttons to choose whether to deactivate only the delegate account or both the delegate and admin accounts
I Implement logic to process user selection by deactivating delegate account only or both delegate account and admin account
I added validation to ensure account is selected, also put post summit validation to ensure the page did not return if the use click back button after deactivation

Screenshots

image
image


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

Copy link
Collaborator

@rshrirohit rshrirohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see inline comment.

Copy link
Collaborator

@rshrirohit rshrirohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the inline change requested. Also, for any account that is not the current user, clicking deactivate account results in 404 error -
image

@sherif-olaboye
Copy link
Contributor Author

Please address the inline change requested. Also, for any account that is not the current user, clicking deactivate account results in 404 error - image

image
this is resolved

@rshrirohit rshrirohit merged commit 4211936 into Release-2024.38 Sep 18, 2024
2 checks passed
@rshrirohit rshrirohit deleted the Develop/Features/TD-4383-Warncentreadminsthatactiveadminaccountexistswheninactivatingdelegateaccount branch September 18, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants