TD-4598 Sign off self-assessment appears when filters applied in Supervisor page though proficiencies are not completed #2838
+45
−121
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link
https://hee-tis.atlassian.net/browse/TD-4598
Description
I refactor CanViewCertificate method to include QuestionsCount and VerifiedCount
I added CompetencySummary class
I added CompetencySummary class to ReviewSelfAssessmentViewModel.cs
I remove and replace the check condition in the ReviewSelfAssessment.cshtml to fixed the signoffrequest button showing when the proficiencies are not completed
I also refactor the certificate action method to remove and replace it with CanViewCertificate method
Screenshots
Adding optional proficiencies after making signoffrequest


Developer checks
(Leave tasks unticked if they haven't been appropriate for your ticket.)
I have: