Skip to content

Conversation

@ABSinhaa
Copy link
Contributor

@ABSinhaa ABSinhaa commented Sep 16, 2024

TD-4384 correction for test failed, using GetDirectURL() instead of path property within the context request object

JIRA link

TD-4384

Description

BackLinks were failing in UAT, when the user feedback questionnaire was being worked on by the user.

Screenshots

Attach screenshots on mobile, tablet and desktop.
image
image
image
image


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

@ABSinhaa ABSinhaa marked this pull request as ready for review September 16, 2024 22:05
@rshrirohit rshrirohit merged commit 3c5b7e8 into Release-2024.38 Sep 18, 2024
2 checks passed
@rshrirohit rshrirohit deleted the Develop/Fixes/TD-4384-TestFailed-Correction branch September 18, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants