Skip to content

Conversation

@Auldrin-Possa
Copy link
Collaborator

@Auldrin-Possa Auldrin-Possa commented Sep 19, 2024

JIRA link

TD-4697

Description

Added AddOptionalCompetencies veiew
Modified code to redirect to AddOptionalCompetencies view when selected optional competencies less than minimum required competencies.
Service method 'HasMinimumOptionalCompetencies' added to check if self assessments has selected minimum required competencies.

Screenshots

image

image

image

image

image


Developer checks

I have:

  • Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

…this page when selected optional competencies less than minmum required
@Auldrin-Possa Auldrin-Possa marked this pull request as ready for review September 19, 2024 10:54
@rshrirohit rshrirohit merged commit c6ecb97 into Release-2024.38 Sep 25, 2024
2 checks passed
@rshrirohit rshrirohit deleted the Develop/feature/TD-4697-prompted-to-choose-optional-proficiencies branch September 25, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants