Skip to content

Conversation

@sherif-olaboye
Copy link
Contributor

JIRA link

https://hee-tis.atlassian.net/browse/TD-4560

Description

I added GroupOptionalCompetencies flag into the Manage optional competencies view model
I display a check box for the group name (H3) as per wireframe
I display the competencies in an expander beneath

Screenshots

image
image
Mobile view
image


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

Copy link
Collaborator

@rshrirohit rshrirohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sherif-olaboye we need this to be pointed to release 38. Please see the parent ticket where the fix version is mentioned.

@sherif-olaboye sherif-olaboye changed the base branch from release-v1.0.0 to Release-2024.38 October 2, 2024 09:48
@sherif-olaboye
Copy link
Contributor Author

Hi @sherif-olaboye we need this to be pointed to release 38. Please see the parent ticket where the fix version is mentioned.

Done

@rshrirohit rshrirohit merged commit 32a402b into Release-2024.38 Oct 8, 2024
2 checks passed
@rshrirohit rshrirohit deleted the Develop/Features/TD-4560-ChangetheManageoptionalcompetenciesviewtoallowselectionofcompetenciesbygroup branch October 8, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants