Skip to content

Conversation

@kevwhitt-hee
Copy link
Contributor

JIRA link

DLSV2-XXXX

Description

Describe what has changed and how that will affect the app. If relevant, add references to the resources you used. Use this as your opportunity to highlight anything odd and give people context around particular decisions.

Screenshots

Attach screenshots on mobile, tablet and desktop.


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

rshrirohit and others added 30 commits May 24, 2024 15:01
…ure/TD-3928-CourseSetupController-refactor

TD-3928-CourseSetupController - refactor
…ure/TD-3927-CCourseContentController-refactor

TD-3927 - CourseContentController - refactor
…ice class added. changes made in respective classes.
…ures/TD-3943-UserFeedbackController-refactor(ControllerServiceRepositorypattern)

TD-3943 user feedback controller refactor(controller service repository pattern)
…ures/TD-3901-MyAccountController-refactor(Controller-Service-Repositorypattern)

TD-3901 my account controller refactor ( controller service repository pattern)
…ure/TD-3897-LearningPortalController-refactor

TD-3897- LearningPortalController - refactor
…ted code from LearningPortlalControllerTests class.
…ure/TD-3899-LearningSolutionsController-refactor

TD-3899-LearningSolutionsController - refactor
…ure/TD-3902-ClaimAccountController-refactor

TD-3902- ClaimAccountController - refactor
…s/TD-3671-Fewcourseswhichdoesnotallowselfenrolment

TD-3671 few courses which does not allow self enrolment
…AdminController-refactor(Controller-Service-Repositorypattern)
…s/TD-3900-LoginControllerRefactor

TD 3900 Login controller refactor
…ure/TD-3904-RegisterAtNewCentreController-refactor

TD-3904-RegisterAtNewCentreController - refactor
…ure/TD-3909-RoleProfilesController-refactor

TD-3909 - RoleProfilesController - refactor
…s/TD-3942-ViewDelegateControllerRefactor

TD 3942 ViewDelegate Controller Refactor
rshrirohit and others added 28 commits August 19, 2024 09:49
…s/TD-4535-CorrectingTableColumnName

TD-4535 Changed the column for storing email in centres table
…s/TD-4238-Launchingfewcoursesfrom'Currentactivities'orfrom'Coursesetup'seeingbacklinkasCompletedactivities'

TD-4238 Launching few courses from 'Current activities' or from 'Course set up' seeing back link as 'Completed activities'
…TD-4436-Enrolment-dateTime-issue

TD-4436- Date saved as UTC datetime and retrieved date as local (time zone) datetime
…atures/TD-4092-RefactorDLSCompetencySelfAssessmentCertificatetoimprovemaintainabilityandsecurity
…ures/TD-4092-RefactorDLSCompetencySelfAssessmentCertificatetoimprovemaintainabilityandsecurity

TD-4092 Refactor dls competency self assessment certificate to improve maintainability and security
…TD-4436-Enrolment-dateTime-issue

TD-4436- Removed DateTime conversion for LastUpdated nullable date field.
…TD-4436-Enrolment-dateTime-issue

TD-4436- Converted utc date to local date time using NodaTime package
… on 'Course set up' & 'Delegate activities' screens
…s/TD-4240-ChangingPrivacyDataLink

TD-4240 Changing privacy data link
…s/TD-4601-AppSettingsChangesForSSOandFreshdesk

TD-4601 AppSettings Changes For SSO and Freshdesk
…TD-4436-UTCdate-And-LocalDateTime

TD-4436 -Stored proc modified to update Completeby date and supervisor in the group enrolment
…oursesshowingon'LearningPortal'notshowingon'Coursesetup&Delegateactivitiesscreensfix
…s/TD-4243-Few'addon'coursesshowingon'LearningPortal'notshowingon'Coursesetup&Delegateactivitiesscreensfix

TD-4243 Few 'add on' courses showing on 'Learning Portal' not showing…
…s/TD-4243-Resolvingduplicateofcourses

Develop/fixes/td 4243 resolving duplicate of courses in enrol activity, available activities and current activities
…ures/TD-4092-RefactorDLSCompetencySelfAssessmentCertificatetoimprovemaintainabilityandsecurity

TD-4092 Resolving certificate showing error 403
@kevwhitt-hee kevwhitt-hee deleted the Develop/Fixes/TD-4455-test-automation branch October 2, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants