Skip to content

Conversation

@Auldrin-Possa
Copy link
Collaborator

JIRA link

TD-4974

Description

Appended table alias to 'CategoryID' field in the SQL query.

Screenshots

image


Developer checks

I have:

  • Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

@Auldrin-Possa Auldrin-Possa marked this pull request as ready for review November 14, 2024 10:33
Copy link
Contributor

@ABSinhaa ABSinhaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good.

@kevwhitt-hee kevwhitt-hee merged commit 5cbd72f into DLS-Release-v1.1.0 Nov 21, 2024
2 checks passed
@kevwhitt-hee kevwhitt-hee deleted the Develop/feature/TD-4974-Limit-supervisors-Request-sign-off branch November 21, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants