Skip to content

Conversation

@Auldrin-Possa
Copy link
Collaborator

JIRA link

TD-4169

Description

SQL query where condition modified to get current/non-deleted framework collaborator.

Screenshots

image

image

image

image

image


Developer checks

I have:

  • Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

@Auldrin-Possa Auldrin-Possa marked this pull request as ready for review November 18, 2024 21:30
@kevwhitt-hee kevwhitt-hee merged commit 52654f9 into DLS-Release-v1.1.1 Nov 21, 2024
2 checks passed
@kevwhitt-hee kevwhitt-hee deleted the Develop/Fix/TD-4169-Framework-contributor-permissions branch November 21, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants