Skip to content

Conversation

@sherif-olaboye
Copy link
Contributor

@sherif-olaboye sherif-olaboye commented Nov 21, 2024

JIRA link

https://hee-tis.atlassian.net/browse/TD-4395

Description

I changed the enrolled label to First enrolled on the Dates partial view and the Index view of view delegate

Screenshots

image
image


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

…me as on 'Delegate activities' for the self assessments
@kevwhitt-hee kevwhitt-hee merged commit 74338b4 into DLS-Release-v1.1.1 Nov 22, 2024
2 checks passed
@kevwhitt-hee kevwhitt-hee deleted the Develop/Fixes/TD-4395'Enrolled'fieldlabelneedstochangeto'Firstenrolled'sameason'Delegateactivities'fortheselfassessments branch November 22, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants