TD-5028 Supervise - Remove staff member doesn't remove the supervisor (For Supervisor when added via 'Add myself to try self-assessment')

[sherif-olaboye]

JIRA link

https://hee-tis.atlassian.net/browse/TD-5028

Description

I check the validation attributes on the SupervisorDelegateViewModel properties. I ensure that all properties of SupervisorDelegateViewModel are bound correctly in the RemoveSupervisorDelegateConfirmed action method

Screenshots

---

Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

• Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
• Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
• Manually tested my work with and without JavaScript
• Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
• Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • doc_1_here
• Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
• Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

[Auldrin-Possa]

Looks good.