TD-4893 Delegate activities - view course delegates resulted in 500 error when course admin field applied filters got deleted

[sherif-olaboye]

JIRA link

https://hee-tis.atlassian.net/browse/TD-4893

Description

I added Q1Options property to Customisation class
I add Q1Options as a parameter in the GetFilterString method
I added a check to the GetFilterString method to clear the cookievalue where is neccessary

Screenshots

---

Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

• Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
• Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
• Manually tested my work with and without JavaScript
• Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
• Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • doc_1_here
• Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
• Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

[Auldrin-Possa]

The proposed solution does not seem appropriate. This may give error if we use number of admin fields with different option names.

[kevwhitt-hee]

As per Auldrin's comment. This looks like it will only partially fix the problem. There are 6 custom prompt fields / answers. I suggest we try to a generic approach of catching the error when applying filters, clearing the filters if there is an error and reloading page with cleared filters, if possible.

[sherif-olaboye]

The proposed solution does not seem appropriate. This may give error if we use number of admin fields with different option names.

Please kindly take a look at the latest push

[sherif-olaboye]

As per Auldrin's comment. This looks like it will only partially fix the problem. There are 6 custom prompt fields / answers. I suggest we try to a generic approach of catching the error when applying filters, clearing the filters if there is an error and reloading page with cleared filters, if possible.

Please kindly take a look at the latest push

[Auldrin-Possa]

Looks good, however some changes need to apply

1. To CheckIfFilterisValid(+)
   • remove response param if not being used.
   • clearFilters param check can be handled by existingFilterString param. Can be removed. (Need to test)
2. Duplicate filters should be handled within or outside of CheckIfFilterisValid(+)

[sherif-olaboye]

Looks good, however some changes need to apply

1. To CheckIfFilterisValid(+)

   • remove response param if not being used.
   • clearFilters param check can be handled by existingFilterString param. Can be removed. (Need to test)

2. Duplicate filters should be handled within or outside of CheckIfFilterisValid(+)

Done

[Auldrin-Possa]

This looks good to me.