TD-4884 Prevent supervisors from confirm self assessments in a category that doesn't match their own

[sherif-olaboye]

JIRA link

https://hee-tis.atlassian.net/browse/TD-4884

Description

I added adminCategoryId to the method parameter and where condition query of GetSelfAssessmentBaseByCandidateAssessmentId and to other places where the method is reference
I added a check to ReviewCompetencySelfAssessment and VerifyMultipleResults action method to ensure that the supervisor that wanted to confirm the assessment request is eligible to do that

Screenshots

---

Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

• Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
• Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
• Manually tested my work with and without JavaScript
• Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
• Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • doc_1_here
• Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
• Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

[kevwhitt-hee]

looks like the autoformatter might need to be run on this? odd whitespace in the first change...

[sherif-olaboye]

ok I will

[sherif-olaboye]

Done

[kevwhitt-hee]

Looks good but can you check that the aurto formatter has been run on the changed files, please, @sherif-olaboye?