TD-5128 Manage Confirmation request - Outstanding request should display only the request that is matching the admin category #3028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lay only the request that is matching the admin category
kevwhitt-hee
requested changes
Dec 17, 2024
| WHERE (LAR.Verified IS NULL) | ||
| AND ((LAR.Result IS NOT NULL) OR (LAR.SupportingComments IS NOT NULL)) | ||
| AND (LAR.Requested IS NOT NULL) | ||
| AND (LAR.Requested IS NOT NULL) AND (au.CategoryID = 0 OR au.CategoryID IN (select CategoryID from SelfAssessments where ID = @selfAssessmentId)) |
There was a problem hiding this comment.
IN seems unnecessary here. The select statement is always going to return only one record since we have ID = in the WHERE clause, so we should use = rather than IN.
rshrirohit
deleted the
Develop/Fixes/TD-5128-ManageConfirmationrequest-Outstandingrequestshoulddisplayonlytherequestthatismatchingtheadmincategory
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link
https://hee-tis.atlassian.net/browse/TD-5128
Description
I modified the query of GetResultSupervisorVerifications method to limit the supervisor to the category that matches the category of the SelfAssessments
Screenshots
Developer checks
(Leave tasks unticked if they haven't been appropriate for your ticket.)
I have: